tests: refactor more tests to use mkfifo_or_skip_

* tests/cp/existing-perm-race: s/mkfifo/mkfifo_or_skip_/
* tests/cp/file-perm-race: Likewise.
* tests/cp/parent-perm-race: Likewise.
* tests/cp/special-f: Likewise.
* tests/dd/reblock: Likewise.
* tests/ls/file-type: Likewise.
* tests/misc/cat-buf: Likewise.
* tests/misc/mknod: Likewise.
* tests/misc/printf-surprise: Likewise.
* tests/misc/selinux: Likewise.
* tests/misc/sort-spinlock-abuse: Likewise.
* tests/misc/stdbuf: Likewise.
* tests/misc/tac-continue: Likewise.
* tests/init.cfg: Improve the error message when skipping.

tests/cp/existing-perm-race

@@ -30,8 +30,7 @@ g2=$2
 
 
 umask 077
-mkfifo fifo ||
-  skip_test_ "fifos not supported"
+mkfifo_or_skip_ fifo
 
 touch fifo-copy &&
 chgrp $g1 fifo &&

tests/cp/file-perm-race

@@ -23,8 +23,7 @@ print_ver_ cp
 require_local_dir_
 
 umask 022
-mkfifo fifo ||
-  skip_test_ "fifos not supported"
+mkfifo_or_skip_ fifo
 
 # Copy a fifo's contents.  That way, we can examine the
 # destination permissions before they're finalized.

tests/cp/parent-perm-race

@@ -29,8 +29,7 @@ chmod g+s d 2>/dev/null # The cp test is valid either way.
 
 for attr in mode ownership
 do
-  mkfifo $attr/fifo ||
-    skip_test_ "fifos not supported"
+  mkfifo_or_skip_ $attr/fifo
 
   # Copy a fifo's contents.  That way, we can examine d/$attr's
   # state while cp is running.

tests/cp/special-f

@@ -20,8 +20,8 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ cp
 
-mkfifo fifo ||
-  skip_test_ "fifos not supported"
+mkfifo_or_skip_ fifo
+
 touch e || framework-failure
 
 

tests/dd/reblock

@@ -39,7 +39,7 @@ EOF
 # until the consumer (dd) opens the fifo therefore
 # increasing the chance that dd will read the data
 # from each printf separately.
-mkfifo dd.fifo || framework_failure
+mkfifo_or_skip_ dd.fifo
 
 dd_reblock_1()
 {

tests/init.cfg

@@ -360,7 +360,7 @@ mkfifo_or_skip_()
     # failure as a test failure.  However, in this case, when running on a SunOS
     # system using a disk NFS mounted from OpenBSD, the above fails like this:
     # mkfifo: cannot make fifo `fifo-10558': Not owner
-    skip_test_ 'NOTICE: unable to create test prerequisites'
+    skip_test_ 'unable to create a fifo'
   fi
 }
 

tests/ls/file-type

@@ -31,7 +31,7 @@ mknod block b 20 20 2> /dev/null && block="block
 "
 mknod char c 10 10 2> /dev/null && char="char
 "
-mkfifo fifo
+mkfifo_or_skip_ fifo
 cd ..
 
 

tests/misc/cat-buf

@@ -24,7 +24,7 @@ print_ver_ cat
 # consumer (dd) opens the fifo therefore increasing
 # the chance that dd will read the data from each
 # write separately.
-mkfifo fifo || framework_failure
+mkfifo_or_skip_ fifo
 
 
 echo 1 > exp

tests/misc/mknod

@@ -19,6 +19,8 @@
 . "${srcdir=.}/init.sh"; path_prepend_ ../src
 print_ver_ mknod
 
+# Ensure fifos are supported
+mkfifo_or_skip_ fifo
 
 umask 777
 

tests/misc/printf-surprise

@@ -48,7 +48,7 @@ require_ulimit_
 # and to make an N-byte-allocating-printf require more than that, thus
 # triggering the printf(3) misbehavior -- which, btw, is required by ISO C99.
 
-mkfifo fifo || framework_failure
+mkfifo_or_skip_ fifo
 
 # Disable MALLOC_PERTURB_, to avoid triggering this bug
 # http://bugs.debian.org/481543#77

tests/misc/selinux

@@ -26,7 +26,7 @@ skip_if_mcstransd_is_running_
 # Create a regular file, dir, fifo.
 touch f || framework_failure
 mkdir d s1 s2 || framework_failure
-mkfifo p || framework_failure
+mkfifo_or_skip_ p
 
 
 # special context that works both with and without mcstransd

tests/misc/sort-spinlock-abuse

@@ -24,7 +24,7 @@ grep '^#define HAVE_PTHREAD_T 1' "$CONFIG_HEADER" > /dev/null ||
   skip_test_ 'requires pthreads'
 
 seq 100000 > in || framework_failure_
-mkfifo fifo || framework_failure_
+mkfifo_or_skip_ fifo
 
 # Arrange for sort to require 5.0+ seconds of wall-clock time,
 # while actually using far less than 1 second of CPU time.

tests/misc/stdbuf

@@ -36,7 +36,7 @@ esac
 # consumer (dd) opens the fifo therefore increasing
 # the chance that dd will read the data from each
 # write separately.
-mkfifo fifo || framework_failure
+mkfifo_or_skip_ fifo
 
 
 # Verify input parameter checking

tests/misc/tac-continue

@@ -53,7 +53,7 @@ seq 5 > in
 
 # Give tac a fifo command line argument.
 # This makes it try to create a temporary file in $TMPDIR.
-mkfifo fifo
+mkfifo_or_skip fifo
 seq 1000 > fifo &
 TMPDIR=$FULL_PARTITION_TMPDIR tac fifo in >out 2>err && fail=1